8377845: Restore regtest for JDK-8324881 with DiagnoseSyncOnValueBasedClasses=2#29722
8377845: Restore regtest for JDK-8324881 with DiagnoseSyncOnValueBasedClasses=2#29722alexmenkov wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into |
|
@alexmenkov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@alexmenkov The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Testcase for JDK-8324881 was mistakenly removed by JDK-8359437 instead of removing only -XX:LockingMode argument.
The fix restores the test case.
Testing: updated test on all platforms
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29722/head:pull/29722$ git checkout pull/29722Update a local copy of the PR:
$ git checkout pull/29722$ git pull https://git.openjdk.org/jdk.git pull/29722/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29722View PR using the GUI difftool:
$ git pr show -t 29722Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29722.diff
Using Webrev
Link to Webrev Comment