8377909: Replace SummaryDiff's array implementation with a hashtable#29717
Draft
jdksjolen wants to merge 1 commit intoopenjdk:masterfrom
Draft
8377909: Replace SummaryDiff's array implementation with a hashtable#29717jdksjolen wants to merge 1 commit intoopenjdk:masterfrom
jdksjolen wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@jdksjolen The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR replaces the array based approach to the
SummaryDiffto a hashtable based one. This allows us to save space, as now we only store the diffs for the MemTags that actually changed. This will become more valuable as the number of MemTags in use increases.As we anticipate most operations to only affect a small number of MemTags I utilize the stack for a small starting array of size 4. This helps us avoid unnecessary
mallocs. In order to avoid unnecessary copying, I also changed a few functions from returningSummaryDiffto taking in one as a reference.Old:
sizeof(SummaryDiff) == 464New:
sizeof(SummaryDiff) == 112Testing: Ran NMT Gtests, currently running tier1-tier3
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29717/head:pull/29717$ git checkout pull/29717Update a local copy of the PR:
$ git checkout pull/29717$ git pull https://git.openjdk.org/jdk.git pull/29717/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29717View PR using the GUI difftool:
$ git pr show -t 29717Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29717.diff