Skip to content

Do not malloc the GrowableArrays in async_get_stack_trace#29714

Draft
jdksjolen wants to merge 1 commit intoopenjdk:masterfrom
jdksjolen:dont-create-gas
Draft

Do not malloc the GrowableArrays in async_get_stack_trace#29714
jdksjolen wants to merge 1 commit intoopenjdk:masterfrom
jdksjolen:dont-create-gas

Conversation

@jdksjolen
Copy link
Contributor

@jdksjolen jdksjolen commented Feb 13, 2026

Hi,

We can just as well stack allocate them, and get rid of a small bit of code. Let's do that. The data arrays are still malloc:ed so we do not risk running out of stack space.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29714/head:pull/29714
$ git checkout pull/29714

Update a local copy of the PR:
$ git checkout pull/29714
$ git pull https://git.openjdk.org/jdk.git pull/29714/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29714

View PR using the GUI difftool:
$ git pr show -t 29714

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29714.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2026

👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 13, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Feb 13, 2026
@openjdk
Copy link

openjdk bot commented Feb 13, 2026

@jdksjolen The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@jdksjolen jdksjolen changed the title Do not malloc the GrowableArray's in async_get_stack_trace Do not malloc the GrowableArrays in async_get_stack_trace Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant