Skip to content

8296183: jndiprovider.properties contains properties pointing to non-existing classes #29712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaikiran wants to merge 3 commits into
base: master
Choose a base branch
from
+3 −21
Open

8296183: jndiprovider.properties contains properties pointing to non-existing classes #29712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b08e3ee
8296183: jndiprovider.properties contains properties pointing to non-…
jaikiran Feb 10, 2026
1864e84
remove reference to a non-existent class from @see of EntryChangeResp…
jaikiran Feb 13, 2026
b68385a
add reference to DefaultResponseControlFactory in javadoc
jaikiran Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions make/modules/java.naming/Java.gmk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# Copyright (c) 2020, 2025, Oracle and/or its affiliates. All rights reserved.
# Copyright (c) 2020, 2026, Oracle and/or its affiliates. All rights reserved.
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
#
# This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -29,6 +29,5 @@ DISABLED_WARNINGS_java += dangling-doc-comments this-escape

DOCLINT += -Xdoclint:all/protected \
'-Xdoclint/package:java.*,javax.*'
CLEAN += jndiprovider.properties

################################################################################
5 changes: 2 additions & 3 deletions src/java.naming/share/classes/com/sun/jndi/ldap/EntryChangeResponseControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 1999, 2002, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1999, 2026, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -51,8 +51,7 @@
* </pre>
*
* @see PersistentSearchControl
* @see com.sun.jndi.ldap.ctl.ResponseControlFactory ResponseControlFactory
* @author Vincent Ryan
* @see DefaultResponseControlFactory
*/
Copy link
Member

@dfuch dfuch Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that it matters much, but I see that DefaultResponseControlFactory and PersistentSearchControl both have an @see EntryChangeResponseControl so I'd suggest to replace:

-  * @see com.sun.jndi.ldap.ctl.ResponseControlFactory ResponseControlFactory
+  * @see DefaultResponseControlFactory

Copy link
Member Author

@jaikiran jaikiran Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point, I've updated the PR accordingly.

public final class EntryChangeResponseControl extends BasicControl {

Expand Down
16 changes: 0 additions & 16 deletions src/java.naming/share/classes/com/sun/jndi/ldap/jndiprovider.properties
View file
Open in desktop

This file was deleted.