Skip to content

8377707: [Linux Alpine] Build failure after JDK-8377368#29710

Open
MBaesken wants to merge 1 commit intoopenjdk:masterfrom
MBaesken:JDK-8377707
Open

8377707: [Linux Alpine] Build failure after JDK-8377368#29710
MBaesken wants to merge 1 commit intoopenjdk:masterfrom
MBaesken:JDK-8377707

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Feb 13, 2026

On Linux Alpine, we get the following build error:

libproc_impl.h:99:4: error: 'off64_t' does not name a type; did you mean 'off_t'?
   99 | off64_t vdso_offset; // offset of vDSO in core
      | ^~~~~~~
      | off_t

and

jdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c:639:11: error: implicit declaration of function 'sendfile64'; did you mean 'sendfile'? [-Wimplicit-function-declaration]
  639 | if (sendfile64(lib_fd, ph->core->core_fd, &ofs, ph->core->vdso_size) == -1) {
      | ^~~~~~~~~~
      | sendfile

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8377707: [Linux Alpine] Build failure after JDK-8377368 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29710/head:pull/29710
$ git checkout pull/29710

Update a local copy of the PR:
$ git checkout pull/29710
$ git pull https://git.openjdk.org/jdk.git pull/29710/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29710

View PR using the GUI difftool:
$ git pr show -t 29710

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29710.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2026

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 13, 2026

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8377707: [Linux Alpine] Build failure after JDK-8377368

Reviewed-by: mdoerr, kevinw, clanger, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • c78a2a8: 8377675: java.net.http tests should not depend on ../../../com/sun/net/httpserver test classes
  • 486ff5d: 8377455: Replace LinkedList with GrowableArray in VM.ThreadDump's OMTable
  • 4e7106d: 8377035: [s390x] Disable JSR166 test cases which uses virtual threads

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8377707: [Linux Alpine] Build failure after JDK-8377368 8377707: [Linux Alpine] Build failure after JDK-8377368 Feb 13, 2026
@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Feb 13, 2026
@openjdk
Copy link

openjdk bot commented Feb 13, 2026

@MBaesken The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 13, 2026
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2026

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing it!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 13, 2026
Copy link
Contributor

@kevinjwalls kevinjwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

off64_t ofs = ph->core->vdso_offset;
if (sendfile64(lib_fd, ph->core->core_fd, &ofs, ph->core->vdso_size) == -1) {
off_t ofs = ph->core->vdso_offset;
if (sendfile(lib_fd, ph->core->core_fd, &ofs, ph->core->vdso_size) == -1) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be os::Linux::sendfile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

6 participants