8376602: [Vector API] Upgrade SLEEF library from v3.6.1 to v3.9 in In…#29703
Draft
xuemingshen-oracle wants to merge 1 commit intoopenjdk:masterfrom
Draft
8376602: [Vector API] Upgrade SLEEF library from v3.6.1 to v3.9 in In…#29703xuemingshen-oracle wants to merge 1 commit intoopenjdk:masterfrom
xuemingshen-oracle wants to merge 1 commit intoopenjdk:masterfrom
Conversation
…cubator Vector API
|
👋 Welcome back sherman! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@xuemingshen-oracle The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Incubator Vector API (jdk.incubator.vector) currently uses SLEEF v3.6.1 for providing SIMD-accelerated transcendental and elementary math functions (e.g., sin, cos, exp, log, pow, hypot) on non-x86 platforms, (specifically aarch64 ? and riscv64 ? / need confirm). This upgrade to SLEEF v3.9 incorporates upstream improvements in accuracy, performance, and scalable vector support
Improvements in v3.9:__ Based on SLEEF changelog (from v3.6.1), key benefits include:
Progress
Error
Integration blocker
8376602. Please make sure it exists and is accessible.Issue
8376602.Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29703/head:pull/29703$ git checkout pull/29703Update a local copy of the PR:
$ git checkout pull/29703$ git pull https://git.openjdk.org/jdk.git pull/29703/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29703View PR using the GUI difftool:
$ git pr show -t 29703Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29703.diff