Skip to content

Conversation

@KristjanESPERANTO
Copy link
Member

@KristjanESPERANTO KristjanESPERANTO commented Dec 30, 2024

As discussed in #341, I have collected changes for the next release here.

My goal for the next release is to take care of low-hanging fruits first. This mainly includes adopting existing easy-to-understand PRs, updating the toolchain a bit and fixing small flaws found along the way.

Major changes and handling reported issues I would plan for after the next release. Steps like these are what I would consider major changes:

  • Replace tools in the toolchain
  • Sharpening the ESLint rules incl. handling the reported issues (this will cause a lot of changes)
  • Switch from CommonJS to ESM

I will leave comments on some of the commits here:

Merged PRs

Solved issues

Not merged PRs

🎆 Running CI with maintained node versions 82d534a

I had to update husky and rework ci.yml for this.

🐞 Fix 'yamlToJson.mjs' 2d28f1c

  • Add missing process import
  • Sort imports
  • Replace 'prettier' by internal function
  • Add console output

Side note: I don't know where the script is used. I noticed during the review that it uses prettier and that prettier is not in the package.json.

Nits

There are some nits like

  • Updating URLs
  • Updating copyright years

Thoughts

After some work on this PR, I think it would have been clearer if I had written my additional changes in separate PRs and used this one as a collector for them.

@KristjanESPERANTO KristjanESPERANTO marked this pull request as draft January 1, 2025 10:16
@KristjanESPERANTO KristjanESPERANTO changed the title Fix 'yamlToJson.mjs' Changes for new release Jan 1, 2025
@KristjanESPERANTO KristjanESPERANTO requested a review from ypid January 1, 2025 14:14
@KristjanESPERANTO
Copy link
Member Author

KristjanESPERANTO commented Jan 1, 2025

@ypid: Before I go any further, can you please check if I'm going in the right direction here? My next step would be to review and (if ok) merge more PRs.

@KristjanESPERANTO
Copy link
Member Author

I think it's more than enough for a release now. Let me know if you don't like anything.

@ypid
Copy link
Member

ypid commented Jan 22, 2025

@KristjanESPERANTO Thanks very much for all your work! I am currently working on a private project in my spare time which should be completed by the end of January, then I will pick up this. Sorry for the delay.

Edit: I will work on this 2025-03-29 -- 30 beginning of 2025-04. Sorry again for the delay. And thanks for your patience!

@KristjanESPERANTO
Copy link
Member Author

No problem, there's no hurry 🙂

@KristjanESPERANTO
Copy link
Member Author

If a rebase helps you to review it or anything else, let me know.

@ypid
Copy link
Member

ypid commented May 21, 2025

This was merged with #479. Thanks for all the work! Feel free to go though the the list of PRs you have merged and close them. GitHub has partly missed them because of the rebases I guess.

@ypid ypid closed this May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants