Add object and array wrapper APIs#45
Open
richerfu wants to merge 1 commit into
Open
Conversation
zig-napi ArkVM benchmark
|
There was a problem hiding this comment.
Pull request overview
Adds several wrapper APIs around existing N-API calls: a generic-keyed SetValue on Object plus propertyNames, isDate, dateValue, freeze, and seal, and on Array adds CreateWithLength, HasElement, and DeleteElement (each with a camelCase alias). Version-gated helpers use options.requireNapiVersion so they fail at compile time on unsupported N-API levels.
Changes:
- New
Objecthelpers for property enumeration, Date inspection, and freezing/sealing, plus a generic-keySetValue. - New
ArrayhelpersCreateWithLength,HasElement, andDeleteElement. - Both new files use
options.requireNapiVersionto gate v5/v8-only features at comptime.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/napi/value/object.zig | Adds SetValue, propertyNames, isDate, dateValue, freeze, seal, plus new Array / options imports. |
| src/napi/value/array.zig | Adds CreateWithLength, HasElement, DeleteElement and their camelCase aliases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+159
to
+166
| pub fn isDate(self: Object) bool { | ||
| comptime options.requireNapiVersion(.v5); | ||
|
|
||
| var result: bool = false; | ||
| const status = napi.napi_is_date(self.env, self.raw, &result); | ||
| if (status != napi.napi_ok) { | ||
| NapiError.last_error = NapiError.Error.withStatus(NapiError.Status.New(status)); | ||
| return false; |
Comment on lines
+106
to
+117
| pub fn SetValue(self: Object, key: anytype, value: anytype) !void { | ||
| const key_raw = try Napi.to_napi_value_auto(self.env, key, null); | ||
| const n_value = try Napi.to_napi_value_auto(self.env, value, null); | ||
| const status = napi.napi_set_property(self.env, self.raw, key_raw, n_value); | ||
| if (status != napi.napi_ok) { | ||
| return NapiError.Error.fromStatus(NapiError.Status.New(status)); | ||
| } | ||
| } | ||
|
|
||
| pub fn setValue(self: Object, key: anytype, value: anytype) !void { | ||
| try self.SetValue(key, value); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.