Add Env wrapper APIs#44
Open
richerfu wants to merge 1 commit into
Open
Conversation
zig-napi ArkVM benchmark
|
There was a problem hiding this comment.
Pull request overview
Adds higher-level Env wrapper methods for common N-API utilities (version, global, symbol, date, exception handling) and exposes the existing NapiValue type as a public API, wiring it through the value-conversion utilities so it can be used as a function argument/return type.
Changes:
- Adds
getNapiVersion,getGlobal,createSymbol,createDate(v5-gated),isExceptionPending, andgetAndClearLastExceptionmethods onEnv. - Exports
NapiValuefrom the publicnapimodule. - Teaches
Napi.valueMatchesType,from_napi_value,to_napi_value, and the no-deinit list aboutNapiValue.NapiValue.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/napi/env.zig | New Env wrapper methods for version, global, symbol, date, and exception helpers. |
| src/napi.zig | Re-exports NapiValue from the public API. |
| src/napi/util/napi.zig | Adds NapiValue handling to type matching, deinit no-op list, and from/to napi conversion paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.