Fix using items in case statements#510
Merged
ccutrer merged 1 commit intoopenhab:mainfrom Jan 28, 2026
Merged
Conversation
Signed-off-by: Cody Cutrer <cody@cutrer.us>
There was a problem hiding this comment.
Pull request overview
This PR adds support for using item proxies in Ruby case statements by implementing the === (case equality) operator. The implementation follows the same pattern as the existing == operator to ensure proxied items can be properly compared in case/when constructs.
Changes:
- Implemented the
===operator for item proxies to delegate to underlying objects - Added tests to verify the case equality operator works correctly with item proxies
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/openhab/core/proxy.rb | Implements the === operator by delegating to underlying objects when comparing proxies of the same class, mirroring the pattern used by the == operator |
| spec/openhab/core/items/proxy_spec.rb | Adds tests for the === operator with rubocop directives to allow case equality testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jimtng
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.