-
-
Notifications
You must be signed in to change notification settings - Fork 288
added QFieldXmlHttpRequest QML HTTP helper #6914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🍎 MacOS DMG universal buildsDownload a MacOS DMG universal build of this PR for testing. 🐧 Linux AppImage buildsDownload a Linux AppImage build of this PR for testing. 🪟 Windows buildsDownload a Windows build of this PR for testing. |
|
🎉 Ta-daaa, freshly created APKs are available for f3da727: arm64-android |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
smaller suggested fixes smaller suggested fixes smaller suggested fixes
47ef0ae to
264c47c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
01e81d6 to
135af48
Compare
135af48 to
e85ee21
Compare
mohsenD98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this PR! The implementation is solid and the XMLHttpRequest-like API will be very intuitive for plugin developers 👍 Just left a minor suggestion.
f01ae34 to
f3da727
Compare
Description
This PR introduces QFieldXmlHttpRequest, a lightweight HTTP request wrapper designed for QML usage (internal QML + plugins).
It follows an XMLHttpRequest-like workflow:
open(), setRequestHeader(), send(), abort(), readyState, response fields, and event-style callback properties.
Usage is via the QField plugin interface (iface), i.e. requests are created with:
iface.createHttpRequest()Credits or Origin
Core idea and API inspiration taken from:
https://github.com/alirezah95/QmlHttpRequest
(Thank you! This PR re-implements/adapts the concept to match QField’s networking stack and safety constraints.)
-Deterministic body encoding: QByteArray sent as-is QString UTF-8 text, QVariantMap / QVariantList JSON