feat: restructure tags to separate sources and parents - WIP#13239
feat: restructure tags to separate sources and parents - WIP#13239stephanegigandet wants to merge 8 commits intomainfrom
Conversation
github-project-automation
bot
moved this to To discuss and validate
in 🍊 Open Food Facts Server issues
|
|
||
| =cut | ||
|
|
||
| sub get_minimal_tags_subset ($tagtype, $tags_ref) { |
There was a problem hiding this comment.
Would this be the function to drop tags in too, or should there be a separate function for this? I reckon the most simple would be to have a list of undesireables (per $tagtype) and check if the current $tagid is in there, and if it is, just drop it and move to the next $tagid?
I think it’d probably be good to do this in a separate function, since get_minimal_tags_subset() seems generally useful, where drop_undesired_tags() can probably get dropped after the transition/conversion.
There was a problem hiding this comment.
Right, we would remove unwanted tags separately.
|
|
/update_tests_results |
github-actions
bot
added
API
|
3 participants
Start of tags refactor: https://docs.google.com/document/d/151UlwHUjxiE3UXde4BB2aXWZdSx6HSE3ot0iqhdGDow/edit?tab=t.0#heading=h.ffj0m6gyxp9