Skip to content

Fixing DatabaseCluster proxysql resource requests#940

Open
Ankit152 wants to merge 3 commits intoopeneverest:mainfrom
Ankit152:proxy-resource-fix
Open

Fixing DatabaseCluster proxysql resource requests#940
Ankit152 wants to merge 3 commits intoopeneverest:mainfrom
Ankit152:proxy-resource-fix

Conversation

@Ankit152
Copy link
Copy Markdown
Contributor

CHANGE DESCRIPTION

Problem:
Issue: #938

Short explanation of the problem.

When creating a DatabaseCluster with proxy.type: proxysql, the everest-operator panics with assignment to entry in nil map inside applyProxySQLCfg. The cluster gets stuck in creating status indefinitely and never provisions any pods.

Related pull requests

  • [link]

Cause:
In defaultSpec(), the ProxySQL spec initializes Resources.Limits but never initializes Resources.Requests, leaving it as a nil map:

ProxySQL: &pxcv1.ProxySQLSpec{
    PodSpec: pxcv1.PodSpec{
        Resources: corev1.ResourceRequirements{
            Limits: corev1.ResourceList{...},  // initialized
            // Requests is nil, never initialized
        },
    },
},

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Helm chart

  • Is the helm chart updated with the new changes? (if applicable)

Jira

  • Is the Jira ticket created and referenced properly?

Tests

  • Is an Integration test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

@Ankit152 Ankit152 requested a review from a team as a code owner March 20, 2026 12:34
@Ankit152 Ankit152 marked this pull request as draft March 20, 2026 12:34
@Ankit152 Ankit152 force-pushed the proxy-resource-fix branch from 5c97c0f to 4a4bf9f Compare March 23, 2026 12:21
Signed-off-by: Ankit152 <ankitkurmi152@gmail.com>
@Ankit152 Ankit152 force-pushed the proxy-resource-fix branch from 4a4bf9f to ed50a45 Compare March 23, 2026 17:00
Signed-off-by: Ankit152 <ankitkurmi152@gmail.com>
Copy link
Copy Markdown
Contributor

@recharte recharte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Ankit152, left a few suggestions.

@Ankit152 Ankit152 force-pushed the proxy-resource-fix branch 2 times, most recently from fc08153 to 0132334 Compare April 6, 2026 08:38
Signed-off-by: Ankit152 <ankitkurmi152@gmail.com>
@Ankit152 Ankit152 force-pushed the proxy-resource-fix branch from 0132334 to 03e0020 Compare April 6, 2026 08:41
@Ankit152 Ankit152 requested a review from recharte April 6, 2026 08:45
@Ankit152 Ankit152 marked this pull request as ready for review April 6, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants