Fixing DatabaseCluster proxysql resource requests#940
Open
Ankit152 wants to merge 3 commits intoopeneverest:mainfrom
Open
Fixing DatabaseCluster proxysql resource requests#940Ankit152 wants to merge 3 commits intoopeneverest:mainfrom
Ankit152 wants to merge 3 commits intoopeneverest:mainfrom
Conversation
5c97c0f to
4a4bf9f
Compare
Signed-off-by: Ankit152 <ankitkurmi152@gmail.com>
4a4bf9f to
ed50a45
Compare
Signed-off-by: Ankit152 <ankitkurmi152@gmail.com>
fc08153 to
0132334
Compare
Signed-off-by: Ankit152 <ankitkurmi152@gmail.com>
0132334 to
03e0020
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Issue: #938
Short explanation of the problem.
When creating a DatabaseCluster with proxy.type: proxysql, the everest-operator panics with assignment to entry in nil map inside applyProxySQLCfg. The cluster gets stuck in creating status indefinitely and never provisions any pods.
Related pull requests
Cause:
In
defaultSpec(), theProxySQLspec initializesResources.Limitsbut never initializesResources.Requests, leaving it as a nil map:Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Helm chart
Jira
Tests