Conversation
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
golangci-lint
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
golangci-lint
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
[golangci-lint] reported by reviewdog 🐶
| @@ -703,7 +703,7 @@ func deleteBackupsForDatabase( | |||
| return false, nil | |||
There was a problem hiding this comment.
[golangci-lint] reported by reviewdog 🐶
| return false, nil | |
| return false, nil |
|
|
||
| installPlanRefs := getInstallPlanRefsForUpgrade(dbEngine, subscription, installPlans) | ||
| result := []everestv1alpha1.OperatorUpgrade{} | ||
| var result []everestv1alpha1.OperatorUpgrade |
There was a problem hiding this comment.
[golangci-lint] reported by reviewdog 🐶
| var result []everestv1alpha1.OperatorUpgrade | |
| var result []everestv1alpha1.OperatorUpgrade |
| func (r *DatabaseEngineReconciler) ensureDBEnginesInNamespaces(ctx context.Context, namespaces []string) ([]reconcile.Request, error) { | ||
| requests := []reconcile.Request{} | ||
| var requests []reconcile.Request | ||
| for _, ns := range namespaces { |
There was a problem hiding this comment.
[golangci-lint] reported by reviewdog 🐶
| for _, ns := range namespaces { | |
| for _, ns := range namespaces { |
| func getDatabaseEngineRequestsFromInstallPlan(_ context.Context, o client.Object) []reconcile.Request { | ||
| result := []reconcile.Request{} | ||
| var result []reconcile.Request | ||
| installPlan, ok := o.(*opfwv1alpha1.InstallPlan) |
There was a problem hiding this comment.
[golangci-lint] reported by reviewdog 🐶
| installPlan, ok := o.(*opfwv1alpha1.InstallPlan) | |
| installPlan, ok := o.(*opfwv1alpha1.InstallPlan) |
|
|
||
| type applier struct { | ||
| *Provider | ||
| ctx context.Context //nolint:containedctx |
There was a problem hiding this comment.
[golangci-lint] reported by reviewdog 🐶
| ctx context.Context //nolint:containedctx | |
| ctx context.Context //nolint:containedctx |
| case everestv1alpha1.EngineSizeSmall: | ||
| haProxy.PodSpec.Resources = haProxyResourceRequirementsSmall | ||
| case everestv1alpha1.EngineSizeMedium: | ||
| haProxy.PodSpec.Resources = haProxyResourceRequirementsMedium |
There was a problem hiding this comment.
[golangci-lint] reported by reviewdog 🐶
| haProxy.PodSpec.Resources = haProxyResourceRequirementsMedium | |
| haProxy.Resources = haProxyResourceRequirementsMedium |
| case everestv1alpha1.EngineSizeMedium: | ||
| haProxy.PodSpec.Resources = haProxyResourceRequirementsMedium | ||
| case everestv1alpha1.EngineSizeLarge: | ||
| haProxy.PodSpec.Resources = haProxyResourceRequirementsLarge |
There was a problem hiding this comment.
[golangci-lint] reported by reviewdog 🐶
| haProxy.PodSpec.Resources = haProxyResourceRequirementsLarge | |
| haProxy.Resources = haProxyResourceRequirementsLarge |
| } | ||
|
|
||
| if a.DB.Spec.Proxy.Replicas != nil { | ||
| haProxy.PodSpec.Size = *a.DB.Spec.Proxy.Replicas |
There was a problem hiding this comment.
[golangci-lint] reported by reviewdog 🐶
| haProxy.PodSpec.Size = *a.DB.Spec.Proxy.Replicas | |
| haProxy.Size = *a.DB.Spec.Proxy.Replicas |
| if a.DB.Spec.Proxy.Replicas != nil { | ||
| haProxy.PodSpec.Size = *a.DB.Spec.Proxy.Replicas | ||
| } else { | ||
| haProxy.PodSpec.Size = a.DB.Spec.Engine.Replicas |
There was a problem hiding this comment.
[golangci-lint] reported by reviewdog 🐶
| haProxy.PodSpec.Size = a.DB.Spec.Engine.Replicas | |
| haProxy.Size = a.DB.Spec.Engine.Replicas |
| } | ||
|
|
||
| if a.DB.Spec.Proxy.Config != "" { | ||
| haProxy.PodSpec.Configuration = a.DB.Spec.Proxy.Config |
There was a problem hiding this comment.
[golangci-lint] reported by reviewdog 🐶
| haProxy.PodSpec.Configuration = a.DB.Spec.Proxy.Config | |
| haProxy.Configuration = a.DB.Spec.Proxy.Config |
CHANGE DESCRIPTION
Problem:
EVEREST-0
Short explanation of the problem.
Related pull requests
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Helm chart
Jira
Tests