Skip to content

Add PS operator support#836

Draft
maxkondr wants to merge 6 commits intomainfrom
EVEREST-2058-PS-PoC
Draft

Add PS operator support#836
maxkondr wants to merge 6 commits intomainfrom
EVEREST-2058-PS-PoC

Conversation

@maxkondr
Copy link
Copy Markdown
Contributor

CHANGE DESCRIPTION

Problem:
EVEREST-0

Short explanation of the problem.

Related pull requests

  • [link]

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Helm chart

  • Is the helm chart updated with the new changes? (if applicable)

Jira

  • Is the Jira ticket created and referenced properly?

Tests

  • Is an Integration test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

@maxkondr maxkondr self-assigned this Jul 22, 2025
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci-lint

[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/applier.go#L373-L373


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/applier.go#L393-L393


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/applier.go#L407-L407


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/applier.go#L408-L408


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/applier.go#L417-L417


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/applier.go#L419-L419


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/applier.go#L425-L425


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/applier.go#L431-L431


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/applier.go#L434-L434


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/applier.go#L437-L437


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/applier.go#L444-L444


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/applier.go#L460-L460


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/applier.go#L499-L499


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/applier.go#L516-L516


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/applier.go#L522-L522


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/applier.go#L541-L541


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/haproxy_configs.go#L27-L27


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/provider.go#L61-L61


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/provider.go#L73-L73


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/provider.go#L102-L102


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/provider.go#L107-L107


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/provider.go#L125-L125


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/provider.go#L131-L131


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/provider.go#L152-L152


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/provider.go#L186-L186


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/provider.go#L222-L222


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/ae32004497aac2822172c63999fcc78fed2e95b9/internal/controller/providers/ps/provider.go#L227-L227

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci-lint

[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/applier.go#L373-L373


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/applier.go#L393-L393


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/applier.go#L407-L407


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/applier.go#L408-L408


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/applier.go#L417-L417


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/applier.go#L419-L419


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/applier.go#L425-L425


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/applier.go#L431-L431


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/applier.go#L434-L434


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/applier.go#L437-L437


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/applier.go#L444-L444


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/applier.go#L460-L460


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/applier.go#L499-L499


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/applier.go#L516-L516


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/applier.go#L522-L522


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/applier.go#L541-L541


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/haproxy_configs.go#L27-L27


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/provider.go#L61-L61


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/provider.go#L73-L73


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/provider.go#L102-L102


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/provider.go#L107-L107


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/provider.go#L125-L125


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/provider.go#L131-L131


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/provider.go#L152-L152


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/provider.go#L186-L186


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/provider.go#L222-L222


[golangci-lint] reported by reviewdog 🐶

https://github.com/percona/everest-operator/blob/f04f369cd6b98229e04e1403338acd50f958ab39/internal/controller/providers/ps/provider.go#L227-L227

@@ -703,7 +703,7 @@ func deleteBackupsForDatabase(
return false, nil
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] reported by reviewdog 🐶

Suggested change
return false, nil
return false, nil


installPlanRefs := getInstallPlanRefsForUpgrade(dbEngine, subscription, installPlans)
result := []everestv1alpha1.OperatorUpgrade{}
var result []everestv1alpha1.OperatorUpgrade
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] reported by reviewdog 🐶

Suggested change
var result []everestv1alpha1.OperatorUpgrade
var result []everestv1alpha1.OperatorUpgrade

func (r *DatabaseEngineReconciler) ensureDBEnginesInNamespaces(ctx context.Context, namespaces []string) ([]reconcile.Request, error) {
requests := []reconcile.Request{}
var requests []reconcile.Request
for _, ns := range namespaces {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] reported by reviewdog 🐶

Suggested change
for _, ns := range namespaces {
for _, ns := range namespaces {

func getDatabaseEngineRequestsFromInstallPlan(_ context.Context, o client.Object) []reconcile.Request {
result := []reconcile.Request{}
var result []reconcile.Request
installPlan, ok := o.(*opfwv1alpha1.InstallPlan)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] reported by reviewdog 🐶

Suggested change
installPlan, ok := o.(*opfwv1alpha1.InstallPlan)
installPlan, ok := o.(*opfwv1alpha1.InstallPlan)


type applier struct {
*Provider
ctx context.Context //nolint:containedctx
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] reported by reviewdog 🐶

Suggested change
ctx context.Context //nolint:containedctx
ctx context.Context //nolint:containedctx

case everestv1alpha1.EngineSizeSmall:
haProxy.PodSpec.Resources = haProxyResourceRequirementsSmall
case everestv1alpha1.EngineSizeMedium:
haProxy.PodSpec.Resources = haProxyResourceRequirementsMedium
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] reported by reviewdog 🐶

Suggested change
haProxy.PodSpec.Resources = haProxyResourceRequirementsMedium
haProxy.Resources = haProxyResourceRequirementsMedium

case everestv1alpha1.EngineSizeMedium:
haProxy.PodSpec.Resources = haProxyResourceRequirementsMedium
case everestv1alpha1.EngineSizeLarge:
haProxy.PodSpec.Resources = haProxyResourceRequirementsLarge
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] reported by reviewdog 🐶

Suggested change
haProxy.PodSpec.Resources = haProxyResourceRequirementsLarge
haProxy.Resources = haProxyResourceRequirementsLarge

}

if a.DB.Spec.Proxy.Replicas != nil {
haProxy.PodSpec.Size = *a.DB.Spec.Proxy.Replicas
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] reported by reviewdog 🐶

Suggested change
haProxy.PodSpec.Size = *a.DB.Spec.Proxy.Replicas
haProxy.Size = *a.DB.Spec.Proxy.Replicas

if a.DB.Spec.Proxy.Replicas != nil {
haProxy.PodSpec.Size = *a.DB.Spec.Proxy.Replicas
} else {
haProxy.PodSpec.Size = a.DB.Spec.Engine.Replicas
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] reported by reviewdog 🐶

Suggested change
haProxy.PodSpec.Size = a.DB.Spec.Engine.Replicas
haProxy.Size = a.DB.Spec.Engine.Replicas

}

if a.DB.Spec.Proxy.Config != "" {
haProxy.PodSpec.Configuration = a.DB.Spec.Proxy.Config
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] reported by reviewdog 🐶

Suggested change
haProxy.PodSpec.Configuration = a.DB.Spec.Proxy.Config
haProxy.Configuration = a.DB.Spec.Proxy.Config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant