Adding permission validations from authz for files page#2941
Adding permission validations from authz for files page#2941jacobo-dominguez-wgu wants to merge 1 commit intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2941 +/- ##
==========================================
- Coverage 95.56% 95.55% -0.01%
==========================================
Files 1349 1351 +2
Lines 31127 31176 +49
Branches 6817 7096 +279
==========================================
+ Hits 29746 29791 +45
+ Misses 1331 1323 -8
- Partials 50 62 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…w, create, edit and delete
94a4751 to
4839aab
Compare
Description
This pr adds authz permission validations for the files page section on the Content menu from the header.
First this validates the enableAuthzCourseAuthoring waffle flag and if it is enabled it checks the permissions from authz on the files page section.
These are the checks included:
Checks for the courses.view_files permission to display or hide the Files option on the header menu. Also renders a permissions denied alert if used a direct link to the files section.
Checks for courses.create_files to display or hide the "+ Add files" button and the add files drop zone.
Checks for courses.delete_files permission to display or hide the Delete menu option on the actions menu and the options menu in card view and list view.
Checks for courses.edit_files to display or hide the Lock/Unlock item on the info section and in the options menu in card view and list view.
Resolves #2934
Useful information to include:
Supporting information
Link to other information about the change, such as GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for manually testing this change.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'