feat: Deprecation Warning when Creating a Legacy Library#2563
Draft
kdmccormick wants to merge 2 commits intoopenedx:masterfrom
Draft
feat: Deprecation Warning when Creating a Legacy Library#2563kdmccormick wants to merge 2 commits intoopenedx:masterfrom
kdmccormick wants to merge 2 commits intoopenedx:masterfrom
Conversation
This reverts commit 8ddb6aa.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2563 +/- ##
========================================
Coverage 94.74% 94.74%
========================================
Files 1218 1218
Lines 27312 27313 +1
Branches 5988 6147 +159
========================================
+ Hits 25878 25879 +1
+ Misses 1376 1363 -13
- Partials 58 71 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the catch Kyle. I'm fine with the banner approach, given this is a temporary warning.
|
5 tasks
Contributor
|
Hi @kdmccormick! I started working on #2876. |
Member
Author
|
Yes please @rpenido ! We were also hoping that this warning would link to the V2 libraries interface, and wouldn't say "Libraries (Beta)". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds this warning banner:
Supporting information
Part of: #2876
Merge considerations
Testing instructions
N/A
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'