feat: replace private by published_at for Dataset#3566
Open
ThibaudDauce wants to merge 6 commits intomainfrom
Open
feat: replace private by published_at for Dataset#3566ThibaudDauce wants to merge 6 commits intomainfrom
private by published_at for Dataset#3566ThibaudDauce wants to merge 6 commits intomainfrom
Conversation
ThibaudDauce
force-pushed
the
replace_private_by_published_at
branch
from
88f48c5 to
1f4df7f
Compare
ThibaudDauce
force-pushed
the
replace_private_by_published_at
branch
from
9f3a372 to
7b17adc
Compare
Contributor
|
How (if) will this be articulated with harvested records? ISO-19139 at least has a "publication date" for the metadata (not processed by udata at this point). I could see
Not saying this needs to be considered at this point nor whether that potential tie is good or bad. Just raising the question, and I can possibly help dig other potential consequences if needed. |
ThibaudDauce
added a commit
that referenced
this pull request
Dec 18, 2025
> 👋 je vois que l'API ne renvoie les activités d'un objet private que pour les super-admin https://github.com/opendatateam/udata/blob/5313356a9ad9c94bbc1cb8ae7615cd4f35debd82/udata/core/activity/api.py#L112-L117 > > Est-ce que ce serait envisageable d'introduire un check de type visible_by_user plutôt ? :warning: need fixing if merged before or after #3566
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix etalab/transport-site#4240
Need to be done for
ReuseandDataservicetoo in other PRs.cdatais working without any change, but could be updated to use and send the newpublished_atfield instead ofprivate.