Clarify that whiteout filenames require a non-empty basename#1314
Open
mahitha-ada wants to merge 2 commits intoopencontainers:mainfrom
Open
Clarify that whiteout filenames require a non-empty basename#1314mahitha-ada wants to merge 2 commits intoopencontainers:mainfrom
mahitha-ada wants to merge 2 commits intoopencontainers:mainfrom
Conversation
Signed-off-by: Mahitha Adapa <mahitha.ada@gmail.com>
mahitha-ada
requested review from
cyphar,
jonjohnsonjr,
sajayantony,
stevvooe,
sudo-bmitch and
tianon
as code owners
sudo-bmitch
requested changes
Apr 16, 2026
| extensions](https://github.com/libarchive/libarchive/wiki/ManPageTar5#pax-interchange-format) as follows: | ||
|
|
||
| - [Windows file attributes](https://msdn.microsoft.com/en-us/library/windows/desktop/gg258117(v=vs.85).aspx) (`MSWINDOWS.fileattr`) | ||
| - [Windows file attributes](<https://msdn.microsoft.com/en-us/library/windows/desktop/gg258117(v=vs.85).aspx>) (`MSWINDOWS.fileattr`) |
Contributor
There was a problem hiding this comment.
Is this change needed?
Contributor
There was a problem hiding this comment.
Suggested change
| - [Windows file attributes](<https://msdn.microsoft.com/en-us/library/windows/desktop/gg258117(v=vs.85).aspx>) (`MSWINDOWS.fileattr`) | |
| - [Windows file attributes](https://msdn.microsoft.com/en-us/library/windows/desktop/gg258117(v=vs.85).aspx) (`MSWINDOWS.fileattr`) |
In that case, lets revert it for consistency.
Co-authored-by: Brandon Mitchell <git@bmitch.net> Signed-off-by: Mahitha Adapa <mahitha.ada@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1301.
Clarifies in the whiteout specification that a
.wh.prefix MUST befollowed by a non-empty basename. The current spec does not explicitly
address the edge case of a bare
.wh.entry (with no basename), whichleads to inconsistent behavior across implementations — for example,
containerd rejects it with "invalid whiteout name: .wh." while other
runtimes may handle it unpredictably.
This change:
.wh.entriesSigned-off-by: Mahitha Adapa mahitha.ada@gmail.com