Skip to content

FPD Status Test Implementation for Cisco Using Functional Translator#5242

Open
RishabhAgarwal-2001 wants to merge 2 commits intomainfrom
rishabh/cisco-fpd-impl
Open

FPD Status Test Implementation for Cisco Using Functional Translator#5242
RishabhAgarwal-2001 wants to merge 2 commits intomainfrom
rishabh/cisco-fpd-impl

Conversation

@RishabhAgarwal-2001
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new test to validate the FPD status translation for Cisco devices. It establishes a robust mechanism to query FPD status using OpenConfig paths by first discovering native FPD names and then applying a functional translator to retrieve and verify their operational state.

Highlights

  • New FPD Status Test: Implemented a new Go test (TestCiscoFPDStatus) to verify the FPD (Field Programmable Device) status translation for Cisco devices using a functional translator.
  • Dynamic FPD Name Discovery: The test dynamically discovers synthetic FPD names by querying native Cisco gNMI paths, addressing limitations in directly querying OpenConfig paths for FPD status.
  • FPD Status Validation: The test retrieves the FPD status for each discovered component via the functional translator and validates it against a predefined set of expected statuses.
  • Deviation Configuration: Added a new fpd_ft deviation field to the Metadata_Deviations proto and its corresponding Go helper function (deviations.FpdFt) to enable and specify the functional translator for FPD paths on Cisco platforms.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link

Pull Request Functional Test Report for #5242 / ebc4eaa

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
FPD-1.1: FPD Status Test
6b82b095 Log
Cisco 8000E status
FPD-1.1: FPD Status Test
f507bad4 Log
Cisco XRd status
FPD-1.1: FPD Status Test
48641570 Log
Juniper ncPTX status
FPD-1.1: FPD Status Test
457ead79 Log
Nokia SR Linux status
FPD-1.1: FPD Status Test
e3c3b985 Log
Openconfig Lemming status
FPD-1.1: FPD Status Test
0b5989c4 Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
FPD-1.1: FPD Status Test
Cisco 8808 status
FPD-1.1: FPD Status Test
Juniper PTX10008 status
FPD-1.1: FPD Status Test
Nokia 7250 IXR-10e status
FPD-1.1: FPD Status Test

Help

@kapilrajput-g
Copy link
Contributor

@RishabhAgarwal-2001 This pr is in progress to move these tests to correct folder:
https://github.com/openconfig/featureprofiles/pull/5240/changes

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a new test for Cisco FPD status using a functional translator, along with the necessary updates to the deviation mechanism. The implementation correctly integrates the new functional translator and adheres to the established patterns for platform-specific deviations. No critical, high, or medium severity issues were identified in the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants