feat(graph): populate driveItem.webUrl per Libre Graph spec#2744
Merged
Conversation
dschmidt
force-pushed
the
feat/driveitem-weburl
branch
2 times, most recently
from
bf3889d to
c70856f
Compare
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | -181 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
dschmidt
force-pushed
the
feat/driveitem-weburl
branch
from
c70856f to
3696007
Compare
The Libre Graph spec declares webUrl on driveItem but cs3ResourceToDriveItem never set it. Build the /f/<resource-id> permalink off the configured public base URL (same source drives.go reads for drive.webUrl) and parse it once at service construction so callers can use it as a plain field.
dschmidt
force-pushed
the
feat/driveitem-weburl
branch
from
3696007 to
a75d89d
Compare
dschmidt
added a commit
to opencloud-eu/n8n-nodes-opencloud
that referenced
this pull request
May 12, 2026
Drop the invented {success, resource, operation, spaceId, path, name}
envelope from folder:create, file:upload, file/folder:copy/move, and
file:download. Resolve the resulting item via Graph after each WebDAV
write and return the driveItem directly, so write outputs match the
read outputs (folder:list, share, user) that already return raw Graph
types. file/folder:delete returns {}.
webUrl on the returned driveItem stays empty until
opencloud-eu/opencloud#2744 lands server-side; once it does, the field
arrives populated without any node-side change.
Closes #7.
dschmidt
added a commit
to opencloud-eu/n8n-nodes-opencloud
that referenced
this pull request
May 12, 2026
Drop the invented {success, resource, operation, spaceId, path, name}
envelope from folder:create, file:upload, file/folder:copy/move, and
file:download. Resolve the resulting item via Graph after each WebDAV
write and return the driveItem directly, so write outputs match the
read outputs (folder:list, share, user) that already return raw Graph
types. file/folder:delete returns {}.
webUrl on the returned driveItem stays empty until
opencloud-eu/opencloud#2744 lands server-side; once it does, the field
arrives populated without any node-side change.
Closes #7.
dschmidt
added a commit
to opencloud-eu/n8n-nodes-opencloud
that referenced
this pull request
May 12, 2026
Drop the invented {success, resource, operation, spaceId, path, name}
envelope from folder:create, file:upload, file/folder:copy/move, and
file:download. Resolve the resulting item via Graph after each WebDAV
write and return the driveItem directly, so write outputs match the
read outputs (folder:list, share, user) that already return raw Graph
types. file/folder:delete returns {}.
webUrl on the returned driveItem stays empty until
opencloud-eu/opencloud#2744 lands server-side; once it does, the field
arrives populated without any node-side change.
Closes #7.
dschmidt
added a commit
to opencloud-eu/n8n-nodes-opencloud
that referenced
this pull request
May 12, 2026
Drop the invented {success, resource, operation, spaceId, path, name}
envelope from folder:create, file:upload, file/folder:copy/move, and
file:download. Resolve the resulting item via Graph after each WebDAV
write and return the driveItem directly, so write outputs match the
read outputs (folder:list, share, user) that already return raw Graph
types. file/folder:delete returns {}.
webUrl on the returned driveItem stays empty until
opencloud-eu/opencloud#2744 lands server-side; once it does, the field
arrives populated without any node-side change.
Closes #7.
micbar
approved these changes
May 12, 2026
Member
micbar
left a comment
micbar
left a comment
There was a problem hiding this comment.
Thanks!
IMHO this is a no brainer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Libre Graph spec declares
webUrlondriveItembutcs3ResourceToDriveItemnever set it, onlydrive.webUrlwas populated.Populate it by parsing the configured public base URL once at service construction and threading it through the shared driveItem builder. Every endpoint that returns drive items now carries the field.