feat: add custom favicon to swagger ui #152 #177
Conversation
|
@peterdudfield plz review |
|
I was hoping we can get an icon in the tab bar of the api, so up here |
|
@peterdudfield plz check the screenshot attached |
|
|
This one doesnt have a swagger route, but it does have a favicorn, I wonder if you could see how it does that? |
|
Sure @peterdudfield , I'll take a look. Was my previous implementation incorrect? |
|
@peterdudfield I refactored the code to use the standard favicon.ico route as requested. Note: This works for the browser tab generally, but the Swagger UI page specifically defaults back to the standard FastAPI (teal) logo because it overrides the browser default. If we want the Quartz logo specifically on the /swagger page, I will need to revert to using the get_swagger_ui_html( swagger_favicon_url=...) method. |
|
@peterdudfield plz have a look at this as well please |
I cant see a push of code? |
|
I didn't push any code because of the reason mentioned above the logo is not visible on the tab |
Oh, yea, im happy with swagger not showing the logo, did you get it working on the other pages? like |
|
Yes they are working fine |
|
@peterdudfield i know you are a bit busy ,But can you plz review this pr? |
|
Sorry, I think we should clsoe this PR now. I think the faviconr icon does appear when not looking at swagger pages, so I think this is needd anymore. Sorry about the confusion here |
|
No problem! I agree since it works on the other pages, it's better to keep the code simple. I'll close this PR now. |
2 participants
Fixes #152
I have added the OCF logo to the Swagger UI docs.
Disabled the default FastAPI docs route.
Added a custom /swagger route that serves the static favicon.
Cleaned up invalid router configurations.
