Adedd Not finding destination account

[WizCoderr]

Fixes - Jira-#MM-458

Didn't create a Jira ticket, click here to create new.

Please Add Screenshots If there are any UI changes.

Before	After

before.webm

After.webm

Please make sure these boxes are checked before submitting your pull request - thanks!

• Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

• If you have multiple commits please combine them into one commit by squashing them.

Summary by CodeRabbit

• Bug Fixes
  • Third-Party Transfer screen now displays context-appropriate prompts based on beneficiary account entry status.
  • Improved interaction by enabling the add beneficiary action when destination account is not yet specified.

[coderabbitai]

Walkthrough

A Compose UI screen modification makes the tip row conditional—when the destination account field is blank, a clickable beneficiary action row displays; otherwise, a spacer renders. Visual styling remains unchanged.

Changes

Cohort / File(s)	Summary
Conditional Tip Row Logic feature/third-party-transfer/src/commonMain/kotlin/org/mifos/mobile/feature/third/party/transfer/thirdPartyTransfer/TptScreen.kt	Added Box import. Replaced static tip row with conditional block: renders Row with tip and clickable action Text when destination account is blank; renders spacer Box otherwise. Style parity retained (labelMedium, secondary/primary colors).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Single file modification with straightforward conditional rendering logic
• No public API changes or complex state interactions
• Visual styling and component usage remain consistent with existing patterns

Poem

🐰 A tip now whispers only when needed be,
Hidden away when the account field runs free,
Clickable guidance for those lost in the flow,
Spacers and logic make destinations glow! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Adedd Not finding destination account' appears to contain a typo ('Adedd' instead of 'Added') and is incomplete, missing key context like 'Add Beneficiary option' mentioned in the full PR summary.	Revise the title to match the full PR objective: 'Add Not finding destination account? Add Beneficiary option' or similar, and fix the typo. The title should be clear and grammatically correct.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 43af85e and d45f7db.

📒 Files selected for processing (1)

• feature/third-party-transfer/src/commonMain/kotlin/org/mifos/mobile/feature/third/party/transfer/thirdPartyTransfer/TptScreen.kt (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: PR Checks KMP / Static Analysis Check

🔇 Additional comments (1)

feature/third-party-transfer/src/commonMain/kotlin/org/mifos/mobile/feature/third/party/transfer/thirdPartyTransfer/TptScreen.kt (1)

15-15: LGTM!

The Box import is correctly added to support the spacer in the conditional layout.

[Nagarjuna0033]

@WizCoderr once check with @therajanmaurya sir about this whether to hide the adding beneficiary option after user selecting both fromAccount and toAccount

[therajanmaurya]

Don't hide, it should be visible all the time

[WizCoderr]

Sir is it correct?

[WizCoderr]

@therajanmaurya please tell what to be updated