curl: Fix header conflict with zblue slist.h#36
Closed
EListenX wants to merge 1 commit intoopen-vela:devfrom
Closed
curl: Fix header conflict with zblue slist.h#36EListenX wants to merge 1 commit intoopen-vela:devfrom
EListenX wants to merge 1 commit intoopen-vela:devfrom
Conversation
chengkai15
reviewed
Oct 10, 2025
curl/CMakeLists.txt
Outdated
| endif() | ||
|
|
||
| target_include_directories(curl PRIVATE ${CURL_INCDIR}) | ||
| target_include_directories(curl BEFORE PRIVATE ${CURL_INCDIR}) |
Contributor
There was a problem hiding this comment.
could we suggest fix it in zblue port?
Replace global header exposure with targeted dependencies to prevent zblue's slist.h from conflicting with curl's slist.h, resolving Curl_slist_append_nodup compilation errors. bug: v/70561 Signed-off-by: v-yichenxi <v-yichenxi@xiaomi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add BEFORE keyword to target_include_directories to ensure curl's slist.h takes precedence over zblue's slist.h, resolving compilation errors with Curl_slist_append_nodup function.
bug: v/70561