fix(active-record): avoid error spans for handled RecordInvalid#2087
Open
aviralgarg05 wants to merge 3 commits intoopen-telemetry:mainfrom
Open
fix(active-record): avoid error spans for handled RecordInvalid#2087aviralgarg05 wants to merge 3 commits intoopen-telemetry:mainfrom
aviralgarg05 wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
dmathieu
reviewed
Mar 16, 2026
Member
dmathieu
left a comment
There was a problem hiding this comment.
What about other errors that usually don't raise either, such as RecordNotFound?
Should the list of exceptions be configurable?
instrumentation/active_record/test/instrumentation/active_record/patches/persistence_test.rb
Show resolved
Hide resolved
Author
Applied these as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #1459 by preventing low-signal error spans for app-handled ActiveRecord bang persistence exceptions.
What changed
Why this is in scope
Tests