Limit CFLAGS suppression to PHP 8.1 only#282
Closed
bobstrecansky wants to merge 2 commits intomainfrom
Closed
Conversation
PHP 8.1.34 has a known issue where the stream cookie functions' signatures don't match the fopencookie API expectations on certain platforms. The compiler is treating this as an error (-Werror). Updating the Dockerfile to add a compiler flag that treats this specific incompatibility as a warning rather than an error.
The -Wno-error=incompatible-pointer-types flag is only needed for PHP 8.1 due to a known fopencookie signature mismatch. Newer PHP versions build without it, so scope the suppression to 8.1 only. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
One or more co-authors of this pull request were not found. You must specify co-authors in commit message trailer via: Supported
Alternatively, if the co-author should not be included, remove the Please update your commit message(s) by doing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Wno-error=incompatible-pointer-typesCFLAGS to PHP 8.1 only, where thefopencookiesignature mismatch is a known issueENV CFLAGSfromDockerfile.alpineand conditionally sets it in the build step for both alpine and debianTest plan
🤖 Generated with Claude Code