Skip to content

Limit CFLAGS suppression to PHP 8.1 only#282

Closed
bobstrecansky wants to merge 2 commits intomainfrom
8.1-cflags-scoped
Closed

Limit CFLAGS suppression to PHP 8.1 only#282
bobstrecansky wants to merge 2 commits intomainfrom
8.1-cflags-scoped

Conversation

@bobstrecansky
Copy link
Copy Markdown
Contributor

Summary

  • Scopes the -Wno-error=incompatible-pointer-types CFLAGS to PHP 8.1 only, where the fopencookie signature mismatch is a known issue
  • Removes the unconditional ENV CFLAGS from Dockerfile.alpine and conditionally sets it in the build step for both alpine and debian
  • Addresses review feedback from Add CFLAGS environment variable to Dockerfile #280

Test plan

  • Verify PHP 8.1 builds succeed on both alpine and debian
  • Verify PHP 8.2+ builds are unaffected (no unnecessary suppression)

🤖 Generated with Claude Code

bobstrecansky and others added 2 commits March 27, 2026 07:53
PHP 8.1.34 has a known issue where the stream cookie functions' signatures don't match the fopencookie API expectations on certain platforms. The compiler is treating this as an error (-Werror).

Updating the Dockerfile to add a compiler flag that treats this specific incompatibility as a warning rather than an error.
The -Wno-error=incompatible-pointer-types flag is only needed for PHP
8.1 due to a known fopencookie signature mismatch. Newer PHP versions
build without it, so scope the suppression to 8.1 only.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bobstrecansky bobstrecansky requested a review from a team as a code owner April 1, 2026 13:49
@linux-foundation-easycla
Copy link
Copy Markdown

CLA Missing ID CLA Not Signed

One or more co-authors of this pull request were not found. You must specify co-authors in commit message trailer via:

Co-authored-by: name <email>

Supported Co-authored-by: formats include:

  1. Anything <id+login@users.noreply.github.com> - it will locate your GitHub user by id part.
  2. Anything <login@users.noreply.github.com> - it will locate your GitHub user by login part.
  3. Anything <public-email> - it will locate your GitHub user by public-email part. Note that this email must be made public on Github.
  4. Anything <other-email> - it will locate your GitHub user by other-email part but only if that email was used before for any other CLA as a main commit author.
  5. login <any-valid-email> - it will locate your GitHub user by login part, note that login part must be at least 3 characters long.

Alternatively, if the co-author should not be included, remove the Co-authored-by: line from the commit message.

Please update your commit message(s) by doing git commit --amend and then git push [--force] and then request re-running CLA check via commenting on this pull request:

/easycla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant