-
Notifications
You must be signed in to change notification settings - Fork 996
chore(deps): update nx to 22.3.0 - manually repaired #6233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update nx to 22.3.0 - manually repaired #6233
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6233 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 316 316
Lines 9558 9558
Branches 2210 2210
=======================================
Hits 9118 9118
Misses 440 440 🚀 New features to boost your workflow:
|
pichlermarc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we had kept it at the old version as the new one does not support Node.js 18 anymore (we nx to run the tests for Node.js 18). lerna is allowed to use a different version since it's only used in publishing.
Note: I don't mind it being updated, just providing some context.
|
@pichlermarc now that you mention it, I remember that issue. Oddly the unit tests passed for 18. I will test locally and if I observe working behavior, I'll merge. |
Which problem is this PR solving?
Updates nx dependency to the latest version, which also deduplicates the nx packages nested in lerna.
Short description of the changes
Type of change
How Has This Been Tested?
Checklist: