feat(instrumentation-pg): propagate context using set application_name#3454
Open
mhennoch wants to merge 5 commits intoopen-telemetry:mainfrom
Open
feat(instrumentation-pg): propagate context using set application_name#3454mhennoch wants to merge 5 commits intoopen-telemetry:mainfrom
mhennoch wants to merge 5 commits intoopen-telemetry:mainfrom
Conversation
Contributor
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
Contributor
|
I haven't checked the code yet, but can you add more tests? I can see that the codecov is failing, so this will need to increase the coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds SET application_name as a context propagation mechanism, following the pattern established for SQL Server (SET CONTEXT_INFO) and Oracle (V$SESSION.ACTION).
Why SET application_name?
PostgreSQL instrumentation already supports SQL Commenter, but it has limitations:
SET application_name operates at the session level and avoids all of these issues.
There is ongoing discussion in the npgsql community about this not being the ideal long-term solution, but no better alternative currently exists for PostgreSQL, and getting to one will take a long time. I will also create a semconv issue about it. This feature is disabled by default, as in the other instrumentations.
Existing and related implementations