Review fixes for servlet-5.0:tomcat-testing#17072
Merged
Conversation
Automated code review of instrumentation/servlet/servlet-5.0/tomcat-testing.
laurit
reviewed
Mar 26, 2026
instrumentation/servlet/servlet-5.0/tomcat-testing/build.gradle.kts
Outdated
Show resolved
Hide resolved
laurit
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated code review of
instrumentation/servlet/servlet-5.0/tomcat-testing.gpt-5.4
Testtask; move it into a dedicatedtestExperimentaltask instead of enabling it unconditionally.Totals: Fixed 2, Needs Manual Fix 1
claude-sonnet-4.6
testInstrumentationreferencedjetty-11.0:javaagentin a Tomcat test module — replaced withtomcat-10.0:javaagent(copy-paste error from jetty-testing module)View workflow run