sdk/trace/internal/observ: guard SpanStarted and spanLive with Enabled#8067
Open
kouji-yoshimura wants to merge 1 commit intoopen-telemetry:mainfrom
Open
sdk/trace/internal/observ: guard SpanStarted and spanLive with Enabled#8067kouji-yoshimura wants to merge 1 commit intoopen-telemetry:mainfrom
kouji-yoshimura wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
|
|
Author
|
@cla-bot check |
dmathieu
approved these changes
Mar 17, 2026
16 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8067 +/- ##
=====================================
Coverage 81.6% 81.6%
=====================================
Files 304 304
Lines 23446 23452 +6
=====================================
+ Hits 19135 19140 +5
- Misses 3929 3930 +1
Partials 382 382
🚀 New features to boost your workflow:
|
dashpole
approved these changes
Mar 17, 2026
flc1125
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guards SpanStarted and spanLive with Enabled(ctx) to avoid building metric
options/attributes when instruments are disabled.
No behavior change when enabled; existing tests cover enabled path.
No CHANGELOG entry, following #7848.
Issue: #7800