test(internal/tools/verifyreadmes): add unit tests for verifyReadme#8066
Open
marcschaeferger wants to merge 1 commit intoopen-telemetry:mainfrom
Open
test(internal/tools/verifyreadmes): add unit tests for verifyReadme#8066marcschaeferger wants to merge 1 commit intoopen-telemetry:mainfrom
marcschaeferger wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Signed-off-by: Marc Schäfer <git@marcschaeferger.de>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8066 +/- ##
=====================================
Coverage 81.6% 81.6%
=====================================
Files 304 304
Lines 23448 23448
=====================================
+ Hits 19140 19141 +1
+ Misses 3926 3925 -1
Partials 382 382 🚀 New features to boost your workflow:
|
dmathieu
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for the
verifyreadmestool.The tests target the
verifyReadmefunction ininternal/tools/verifyreadmes/main.go, which is responsible for ensuringthat each Go module directory contains a
README.md.Test coverage includes:
filepath.Walkgo.modREADME.mdexists alongsidego.modREADME.mdis missingThe missing README test validates the exact error message rather than
only asserting the presence of an error, addressing review feedback from
the previous attempt in #7026.
No changes were made to production code. This PR only introduces tests.
--> So no need to update the Changelog?
The following commands were run without any issue.
Closes #6604