attribute: investigate and fix unexpected panic in unreachable code paths#8062
Open
NETIZEN-11 wants to merge 2 commits intoopen-telemetry:mainfrom
Open
attribute: investigate and fix unexpected panic in unreachable code paths#8062NETIZEN-11 wants to merge 2 commits intoopen-telemetry:mainfrom
NETIZEN-11 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
- Replace panic with graceful handling in hashKV function - Treat unknown types as EMPTY to maintain hash consistency - Add comprehensive tests to verify the fix - Prevent crashes from corrupted data or future type additions Fixes issue open-telemetry#8047: panic in places that should be unreachable
NETIZEN-11
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu,
flc1125 and
pellared
as code owners
|
|
dmathieu
added
the
blocked:CLA
pellared
requested changes
Mar 16, 2026
Member
pellared
left a comment
pellared
left a comment
There was a problem hiding this comment.
This is the opposite of what the issue is about
NETIZEN-11
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR investigates the panic occurring in code paths that are assumed to be unreachable in the attribute handling logic.
The panic indicates that a supposedly unreachable case can actually occur during runtime, which suggests a bug in the attribute processing or hashing logic.
Problem
Currently, certain parts of the attribute implementation rely on
panic()when encountering cases that are assumed to be unreachable. However, when unexpected attribute values or types propagate into these paths, the program may crash.This behavior was reported in issue #8047.
Changes
Testing
Fixes: #8047