sdk/trace: TraceIDRatioBased sampler with tracestate support#8059
Draft
yuanyuanzhao3 wants to merge 2 commits intoopen-telemetry:mainfrom
Draft
sdk/trace: TraceIDRatioBased sampler with tracestate support#8059yuanyuanzhao3 wants to merge 2 commits intoopen-telemetry:mainfrom
yuanyuanzhao3 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the TraceIDRatioBased sampler with OpenTelemetry tracestate support per the TraceState: Probability Sampling specification.
Part of #7928 (Support TraceIdRatioBased Sampler).
Changes
TraceIDRatioBased sampler
otkey: When sampling, encodes the rejection threshold in thethsub-key (e.g.th:8for 50% sampling).rvsub-key when present; otherwise uses the least-significant 56 bits of the TraceID (per W3C Trace Context Level 2).FlagsRandom), the sampler erases thethvalue in tracestate, as required for unknown sampling probability.AlwaysOn sampler
th:0when sampling to indicate 100% sampling probability.Testing
TestTracestateRandomness: Parsing of thervsub-key.TestEraseTraceStateThKeyValue: Erasure ofthin all positions.TestInsertOrUpdateTraceStateThKeyValue: Insert/update ofth.TestTraceIDRatioSamplerShouldSample: Sampling behavior with tracestate.TestTracestateIsPassed: Tracestate propagation across samplers.TestTraceIdRatioSamplesInclusively: TraceIDRatioBased inclusion property.Related
Co-Author
Joshua MacDonald jmacd@users.noreply.github.com