fix(semconv): use Observable instrument types for process metrics#8026
Open
Br1an67 wants to merge 1 commit intoopen-telemetry:mainfrom
Open
fix(semconv): use Observable instrument types for process metrics#8026Br1an67 wants to merge 1 commit intoopen-telemetry:mainfrom
Br1an67 wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Update the weaver.yaml instrument map to use Observable variants for all process metrics. This allows these metrics to be properly instrumented using callback functions, which is the recommended pattern for system-level metrics that are read from /proc or similar sources. Metrics updated: - process.context_switches: Int64ObservableCounter - process.cpu.utilization: Float64ObservableGauge - process.disk.io: Int64ObservableCounter - process.memory.usage: Int64ObservableUpDownCounter - process.memory.virtual: Int64ObservableUpDownCounter - process.network.io: Int64ObservableCounter - process.paging.faults: Int64ObservableCounter - process.thread.count: Int64ObservableUpDownCounter - process.unix.file_descriptor.count: Int64ObservableUpDownCounter - process.uptime: Float64ObservableGauge - process.windows.handle.count: Int64ObservableUpDownCounter Signed-off-by: root <root@C20251020184286.local>
Br1an67
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu,
flc1125 and
pellared
as code owners
|
|
dmathieu
added
the
blocked:CLA
Author
|
/easycla |
Br1an67
force-pushed
the
fix/issue-7342-observable-metrics
branch
from
8545623 to
222cf50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7342
Summary
Update the weaver.yaml instrument map to use Observable variants for all process metrics. This allows these metrics to be properly instrumented using callback functions, which is the recommended pattern for system-level metrics that are read from /proc or similar sources.
The OpenTelemetry semantic conventions recommend using Observable instruments for process metrics since they represent values that are typically read from the operating system at observation time rather than being incrementally updated.
Changes
instrumenttext map insemconv/templates/registry/go/weaver.yamlprocess.context_switches:Int64ObservableCounterprocess.cpu.utilization:Float64ObservableGaugeprocess.disk.io:Int64ObservableCounterprocess.memory.usage:Int64ObservableUpDownCounterprocess.memory.virtual:Int64ObservableUpDownCounterprocess.network.io:Int64ObservableCounterprocess.paging.faults:Int64ObservableCounterprocess.thread.count:Int64ObservableUpDownCounterprocess.unix.file_descriptor.count:Int64ObservableUpDownCounterprocess.uptime:Float64ObservableGaugeprocess.windows.handle.count:Int64ObservableUpDownCounterTesting
go.*,system.*)