[DO NOT MERGE] [WIP] attribute: add SLICE Type#7944
Draft
pellared wants to merge 13 commits intoopen-telemetry:mainfrom
Draft
[DO NOT MERGE] [WIP] attribute: add SLICE Type#7944pellared wants to merge 13 commits intoopen-telemetry:mainfrom
pellared wants to merge 13 commits intoopen-telemetry:mainfrom
Conversation
pellared
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu and
flc1125
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7944 +/- ##
=======================================
- Coverage 81.7% 81.4% -0.4%
=======================================
Files 304 304
Lines 23287 23366 +79
=======================================
- Hits 19039 19031 -8
- Misses 3862 3890 +28
- Partials 386 445 +59
🚀 New features to boost your workflow:
|
pellared
commented
Feb 24, 2026
Comment on lines
+85
to
+90
| h = h.Uint64(sliceID) | ||
| rv := reflect.ValueOf(kv.Value.slice) | ||
| for i := 0; i < rv.Len(); i++ { | ||
| v := rv.Index(i).Interface().(Value) | ||
| h = hashKV(h, KeyValue{Key: "", Value: v}) | ||
| } |
Member
Author
There was a problem hiding this comment.
@dashpole, PTAL
I think that this is correct, but I prefer to double-check with you.
pellared
commented
Feb 25, 2026
| } | ||
| if val.Type() == STRING { | ||
| b.WriteRune('"') //nolint:revive // No need to check error for strings.Builder. | ||
| b.WriteString(val.Emit()) //nolint:revive // No need to check error for strings.Builder. |
Member
Author
There was a problem hiding this comment.
What if it contains "? The value would have to be escaped.
| b.WriteString(val.Emit()) //nolint:revive // No need to check error for strings.Builder. | ||
| b.WriteRune('"') //nolint:revive // No need to check error for strings.Builder. | ||
| } else { | ||
| b.WriteString(val.Emit()) //nolint:revive // No need to check error for strings.Builder. |
Member
Author
There was a problem hiding this comment.
What if a FLOAT64 contains NaN, +Inf, -Inf?
pellared
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This should not be merged before we have a v1.41.0 release.
Fixes #7934
Prototype PR: #6809
I decided to print the slice values in
Emitimplementation in a similar way to the other homogeneous slice values that is based on JSON.I also made a prototype for efficient (not safe) retrieval of the slice value (mainly for the SDK): #7949