Skip to content

Conversation

@hwindlas
Copy link
Contributor

@hwindlas hwindlas commented Feb 1, 2026

Description

This pull request updates the Kubernetes diagnostics collection process in CI workflows to be more flexible and robust. The main improvements are the addition of configurable arguments for diagnostics, refactoring of the diagnostics action for better modularity, and improved artifact naming and collection. It also updates copyright years.

Diagnostics Collection Improvements:

  • The .github/actions/collect_diagnostics/action.yaml action now accepts an input parameter k8s_diagnostics_args, allowing customization of arguments passed to orch_k8s_diagnostics.py (e.g., --errors-only --output-html --output-json). The default is set to include errors only and output in HTML and JSON.
  • The diagnostics collection steps are refactored for clarity and modularity: running the diagnostics utility, collecting cluster info, collecting pod logs, and uploading artifacts are now separate steps. Artifact naming is improved to include job and event context, and additional files are included in the upload.

Workflow Updates:

  • In .github/workflows/virtual-integration.yml, diagnostics collection is now run after relevant job steps in multiple jobs (virtual-integration, deploy-on-prem, etc.), each time with appropriate k8s_diagnostics_args for the scenario. [1] [2] [3]
  • The diagnostics step is removed from its previous location and added after more job steps to ensure it runs regardless of earlier failures and collects the most complete information.

General/Other:

  • The copyright year in both the action and workflow files is updated from 2025 to 2026. [1] [2]
  • The actions/checkout step now uses a token for authentication with the orch-ci repository.

Fixes # (issue)

Any Newly Introduced Dependencies

Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I agree to use the APACHE-2.0 license for my code changes
  • I have not introduced any 3rd party dependency changes
  • I have performed a self-review of my code

@hwindlas hwindlas requested a review from mparamas-zz February 2, 2026 07:21
@hwindlas hwindlas marked this pull request as ready for review February 6, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant