-
Notifications
You must be signed in to change notification settings - Fork 22
Orchestrator K8S Diagnostics Utility #1390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hwindlas
wants to merge
24
commits into
main
Choose a base branch
from
hw_orchK8Sdiagnostics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the Kubernetes diagnostics collection process in CI workflows to be more flexible and robust. The main improvements are the addition of configurable arguments for diagnostics, refactoring of the diagnostics action for better modularity, and improved artifact naming and collection. It also updates copyright years.
Diagnostics Collection Improvements:
.github/actions/collect_diagnostics/action.yamlaction now accepts an input parameterk8s_diagnostics_args, allowing customization of arguments passed toorch_k8s_diagnostics.py(e.g.,--errors-only --output-html --output-json). The default is set to include errors only and output in HTML and JSON.Workflow Updates:
.github/workflows/virtual-integration.yml, diagnostics collection is now run after relevant job steps in multiple jobs (virtual-integration,deploy-on-prem, etc.), each time with appropriatek8s_diagnostics_argsfor the scenario. [1] [2] [3]General/Other:
actions/checkoutstep now uses a token for authentication with theorch-cirepository.Fixes # (issue)
Any Newly Introduced Dependencies
Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: