added information about nullable fields in response#189
Draft
Ravinskij-Vladimir wants to merge 1 commit intomainfrom
Draft
added information about nullable fields in response#189Ravinskij-Vladimir wants to merge 1 commit intomainfrom
Ravinskij-Vladimir wants to merge 1 commit intomainfrom
Conversation
Contributor
Ravinskij-Vladimir
commented
Aug 6, 2025
Ravinskij-Vladimir
commented
Like that
MaxSazanov
reviewed
Aug 6, 2025
Contributor
MaxSazanov
left a comment
MaxSazanov
left a comment
There was a problem hiding this comment.
В остальных response из web-adapter всё есть?
| @Schema(nullable = true, description = "Email may be null") | ||
| private final String email; | ||
| private final String firstName; | ||
| private final String lastName; |
Contributor
There was a problem hiding this comment.
lastName не обязательно передаётся нам из тг
| @@ -10,6 +11,7 @@ public class JwtResponse { | |||
| private final String type = "Bearer"; | |||
| private final UUID id; | |||
| private final String username; | |||
Contributor
There was a problem hiding this comment.
username берется из тг, где он не обязателен
| @@ -12,12 +13,17 @@ public record MeResponse( | |||
| Long tgId, | |||
| String firstName, | |||
| String lastName, | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.