Print out a message when there is a file created to store constant tensors#3413
Open
Print out a message when there is a file created to store constant tensors#3413
Conversation
Signed-off-by: Tung D. Le <tung@jp.ibm.com>
tungld
commented
Mar 9, 2026
| .exec(); | ||
| } catch (const onnx_mlir::CommandException &error) { | ||
| if (Verbose) { | ||
| if (VerboseOutput) { |
Member
Author
There was a problem hiding this comment.
To fix a warning: Verbose is an enum constant. This should be the compile option -v (VerboseOuput).
tungld
commented
Mar 9, 2026
| bool storeConstantsToFile, uint64_t constantsToFileSingleThreshold, | ||
| uint64_t constantsToFileTotalThreshold, std::string outputNameNoExt, | ||
| bool storeConstantsToFile, float constantsToFileSingleThreshold, | ||
| float constantsToFileTotalThreshold, std::string outputNameNoExt, |
Member
Author
There was a problem hiding this comment.
This is a bug. I fixed it.
tungld
commented
Mar 9, 2026
| } | ||
| showCompilePhase("Compilation completed"); | ||
| std::string completeMsg = | ||
| "Compilation completed. Generated \"" + outputNameWithExt + "\""; |
Member
Author
There was a problem hiding this comment.
Print out the generated .so file's name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds code to print out a message when there is a file created to store constant tensors, the message is like this: