Apply 'EXCLUDE_FROM_ALL' to the directory when ONNX_MLIR_BUILD_TESTS is not ON#3287
Open
Apply 'EXCLUDE_FROM_ALL' to the directory when ONNX_MLIR_BUILD_TESTS is not ON#3287
Conversation
Collaborator
|
Can one of the admins verify this patch? |
AlexandreEichenberger
approved these changes
Dec 5, 2025
Collaborator
AlexandreEichenberger
left a comment
There was a problem hiding this comment.
LGTM, thanks
Collaborator
|
I see that the DCO was not satisfactorily signed. Can you confirm @mschofie that you obeyed by the DCO rules as listed in our repo. I can then override them and merge the PR. Tx |
Author
|
Apologies! Yes. I confirm that this change conforms to the DCO rules in this repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3285.
ONNX_MLIR_BUILD_TESTSis documented as controlling whether the test executables are built. But it doesn't appear to be honored - even when I set it toOFF, the tests are still built. The problem appears to be with the use ofEXCLUDE_FROM_ALL- when attempting to opt-out of tests, the CMake variableEXCLUDE_FROM_ALLis set toON- however CMake only documentsEXCLUDE_FROM_ALLproperties applied to Directories (documentation) or Targets (documentation). This change:ONNX_MLIR_BUILD_TESTSto set theEXCLUDE_FROM_ALLproperty on the current Directory.:/test/multiple-models/CMakeLists.txtup to:/test/CMakeLists.txtto apply to all of:/testI've validated with "Ninja Multi-Config" and "Visual Studio 17 2022" generators on Windows. Without the fix, running a CMake build with no target specified, and
ONNX_MLIR_BUILD_TESTSset toOFFwill build the test targets. With the fix, the test targets aren't built by default, but will build when a target is specifically requested.