Skip to content

Make all implicit re-exports explicit#1758

Open
e10e3 wants to merge 3 commits intoonline-ml:mainfrom
e10e3:typing-implicit-reexport
Open

Make all implicit re-exports explicit#1758
e10e3 wants to merge 3 commits intoonline-ml:mainfrom
e10e3:typing-implicit-reexport

Conversation

@e10e3
Copy link
Contributor

@e10e3 e10e3 commented Feb 26, 2026

Currently, River allows most modules to use implicitly re-exported variables (the error check is disabled).
It turns out there were only two cases where MyPy found this error, both in the optim module. I chose to re-export both because it would make sense to load them from these files (this is in fact where they were originally defined, before a refactor).

With these cases fixed, the rule can now be enabled everywhere.

@e10e3
Copy link
Contributor Author

e10e3 commented Feb 26, 2026

This change just showed its use: a previous PR used a tangled import instead of directly importing a module.
I should have rebased before pushing.

Let me fix that.

@e10e3 e10e3 force-pushed the typing-implicit-reexport branch from 1d48fc7 to 3574272 Compare February 26, 2026 17:13
@e10e3
Copy link
Contributor Author

e10e3 commented Feb 26, 2026

There's an error in the doctest of multioutput.chain.ClassifierChain, saying “OpenMLError: Dataset yeast with version 4 not found.” I can't reproduce it on my side. Maybe a network error from GitHub?

@MaxHalford
Copy link
Member

Does the error persist?

@e10e3
Copy link
Contributor Author

e10e3 commented Mar 15, 2026

Does the error persist?

I still can't reproduce the error on my side, making me think it's a transient error. The only way to know if it's still present in CI is to re-run the job (but I need someone with the rights to do so).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants