Open
Conversation
Contributor
Author
|
This change just showed its use: a previous PR used a tangled import instead of directly importing a module. Let me fix that. |
1d48fc7 to
3574272
Compare
Contributor
Author
|
There's an error in the doctest of |
Member
|
Does the error persist? |
Contributor
Author
I still can't reproduce the error on my side, making me think it's a transient error. The only way to know if it's still present in CI is to re-run the job (but I need someone with the rights to do so). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, River allows most modules to use implicitly re-exported variables (the error check is disabled).
It turns out there were only two cases where MyPy found this error, both in the
optimmodule. I chose to re-export both because it would make sense to load them from these files (this is in fact where they were originally defined, before a refactor).With these cases fixed, the rule can now be enabled everywhere.