Sync pre-commit's repo versions with Poetry#1676
Merged
gbolmier merged 2 commits intoonline-ml:mainfrom May 15, 2025
Merged
Conversation
The tool versions listed for pre-commit were different from the ones in poetry.lock, leading to different behaviour between a local invocation and from pre-commit. In the case of MyPy, pre-commit's version was severely outdated, causing false positives and false negatives.
gbolmier
approved these changes
Apr 10, 2025
Contributor
Author
|
As a note, one of the unit tests failed, but I cannot reproduce the failure on my side. I believe this error is just some flakiness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tool versions listed for pre-commit were different from the ones in
poetry.lock, leading to different behaviour between a local invocation and from pre-commit.In the case of MyPy, pre-commit's version was severely outdated, causing false positives and false negatives.
When River's dependencies are updated, pre-commit's configuration should be updated to have the same versions.
I realise now that this is one of the causes of #1665; but this PR does not solve the main problem of dependencies between files anyway.