Conversation
Let's first test the build of the WASM wheels in an independant workflow so that it is easier to iterate and make sure it works before adding the logic to the pypi workflow.
e780d5f to
e0fb7b5
Compare
e0fb7b5 to
c2b840e
Compare
|
Great stuff @gbolmier! For the pandas version, I guess it's fine to loosen it on our end. |
I would prefer too, if possible. @agriyakhetarpal do you remember why you bumped pandas from I just realized that Pyodide is not supporting NumPy @agriyakhetarpal does it mean that we need to wait for Pyodide to support newer pandas and NumPy versions in order to test River's WASM build? |
|
Hi @gbolmier, sorry for the late response – this PR got buried in my notifications! Yes, you are right. We will currently need to wait for a Pyodide release to be able to grab NumPy >= 2.0 and pandas >= 2.2.3. The reason for bumping |
|
Hi @gbolmier and @MaxHalford, Pyodide 0.27 has been released on 01/01/2025: https://github.com/pyodide/pyodide/releases/tag/0.27.0 We should be able to go ahead with this PR now 🚀 This does require pypa/cibuildwheel#2117, though – but we may switch to the non- Here's an example workflow if you'd like: https://github.com/scikit-image/scikit-image/blob/107c1a9a2c49f86668c41e8e5a1c101d71ff122f/.github/workflows/emscripten.yml, which just needs the |
Let's first test the build of the WASM wheels in an independant workflow so that it is easier to iterate and make sure it works before adding the logic to the pypi workflow.
See #1649 thread for more context.
Current blocker is a conflict between River
pandas<3.0.0,>=2.2.3requirement and Pyodide pandas version (2.2.0) (see run error).