Skip to content

Have a "Next" button for lessons#3421

Open
GreenAsJade wants to merge 1 commit intoonline-go:mainfrom
GreenAsJade:learning_pages_next
Open

Have a "Next" button for lessons#3421
GreenAsJade wants to merge 1 commit intoonline-go:mainfrom
GreenAsJade:learning_pages_next

Conversation

@GreenAsJade
Copy link
Collaborator

@GreenAsJade GreenAsJade commented Feb 28, 2026

Fixes the solution disappearing before you have a chance to absorb the lesson.

As suggested here: https://forums.online-go.com/t/idea-add-next-button-to-learn-exercises/59464?u=greenasjade

Proposed Changes

  • Have a "Next" button in the same place as "Retry" for failed lessons

(I think we don't have lessons in dev - I don't seem to - so I tested this pointing at Prod instead of e2e. I like the feel of it).

@github-actions
Copy link

Reviewed the changes. No bugs or performance issues found. The removal of both setTimeout(this.next, 1000) calls is consistent — both completion paths (onUpdate-based via complete() and onCorrectAnswer-based via correct_answer_triggered) correctly surface the Next button through the render's correct flag. As a side effect, this also eliminates a subtle pre-existing issue where multiple timeout callbacks could queue up if onUpdate fired repeatedly while complete() was true.

@anoek
Copy link
Member

anoek commented Mar 1, 2026

So I borrowed this behavior, and a lot about the lessons really, from lichess. They default to this auto-next, and I think for the initial stuff it's probably mostly desired to not have to do two clicks to progress through, but I also get wanting to take a moment especially once you get out of the first lessons.

Lichess solves this by having a toggle

image

I'm wondering if we should do something similar, default to the auto advance, and then when you're ready to slow down a little, toggle that option off. We could put it maybe either at the bottom of the list on the left, or at the bottom of the contents on the right, or have a gear icon that has that option in it to auto-advance or not. What do you guys think?

@denishowe
Copy link

An option would be perfect. I didn't want to complicate the dev work but I agree absolutely that you want to be able to go fast or slow depending on how easy you're finding it.

@GreenAsJade
Copy link
Collaborator Author

GreenAsJade commented Mar 1, 2026

I too thought that a choice would be nice, but the UI of it wasn't clear, and I personally found that the click-to-proceed behaviour is a better default than jumping to the next straight away.

I think this because it encourages reflection and learning, and because the button is right where it should be.

For the questions with answers (like how many ataris) you just clicked the radio button, your cursor is right there over the "next" button that appears under it. Maybe you don't need to look back at the board to see that "yes I'm glad I was right", but you can glance before clicking.

For puzzles, your cursor is where you clicked, over the board, and you should reflect on the resulting board position when it is correct, to let it sink in.

Of course, we all know I'm not a UI designer, but that was my thinking and experience with it.

(And this is a desktop-oriented line of thinking! 🤔 Mobile might be another thing altogether...)

I did wonder whether "radio button lessons" should auto advance, and puzzles should not, but that becomes jarring inconsistent behaviour.

I'm totally happy to add a toggle at a UI design-rapproved place ... personally I'd default it to "don't proceed", and let impatient "tick the box and move on" people change it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants