[Scheduled Callbacks] Add optional system transaction ID argument#1627
Merged
peterargue merged 5 commits intoonflow:masterfrom Sep 3, 2025
Merged
Conversation
j1010001
requested review from
Kay-Zee,
janezpodhostnik,
joshuahannan,
peterargue and
zhangchiqing
zhangchiqing
approved these changes
Sep 2, 2025
peterargue
reviewed
Sep 2, 2025
Contributor
peterargue
left a comment
peterargue
left a comment
There was a problem hiding this comment.
looks good. added some suggestions for improving the docs. please regenerate if accepted
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
janezpodhostnik
approved these changes
Sep 3, 2025
peterargue
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: onflow/flow-go#7784 and onflow/flow-go#7804
Description
Adds an optional transaction ID argument to the get system transaction / result. This is because now system collection will also include scheduled callbacks so we want to make sure it is possible to fetch those results as well.
For contributor use:
masterbranchFiles changedin the Github PR explorer