Port #4397: Check move operator for resource-typed extra arguments by Copilot · Pull Request #4399 · onflow/cadence

Copilot · 2026-01-04T17:46:31Z

Description

Ports the fix from #4397 (merged to v1.8) to master. Extends move operator validation to cover variadic arguments in function invocations.

Previously, only required parameters were checked for proper move semantics when passing resources. Variadic arguments bypassed this validation, allowing invalid resource moves or missing move operators to go undetected.

Changes:

sema/check_invocation_expression.go: Call checkInvocationArgumentMove for extra arguments
sema/account_test.go: Added tests verifying move operator validation on resource-typed variadic arguments

Example:

access(all) resource R {
    access(all) fun addToAccount(_ account: auth(Contracts) &Account) {
        account.contracts.add(
            name: "foo",
            code: "012".decodeHex(),
            <- self,  // Now properly rejected: cannot move self
        )
    }
}

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

Original prompt

Port #4397 to master

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: turbolent <51661+turbolent@users.noreply.github.com>

turbolent · 2026-01-04T17:58:32Z

@copilot Compare the diff of the new PR with the diff of the original PR

Copilot · 2026-01-04T18:02:07Z

@copilot Compare the diff of the new PR with the diff of the original PR

Comparison complete:

Code changes are identical between the original PR #4397 and this port to master. Both PRs modify:

sema/check_invocation_expression.go: Add checkInvocationArgumentMove call for extra arguments (6 lines changed)
sema/account_test.go: Add 2 test cases for resource move validation (42 lines added)

Only difference:

This PR includes an additional .gitignore change (adds *.orig pattern) from cleanup of backup files created during porting. This change is not in the original PR [v1.8] Check move operator for resource-typed extra arguments #4397.

The git index hashes differ due to different base commits (v1.8 vs master), but the actual code changes are functionally identical.

github-actions · 2026-01-05T14:17:10Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

github-actions · 2026-01-05T14:22:22Z

Benchstat comparison

Base branch: onflow:master
Base commit: d6e33c4

Results

	old.txt	new.txt
	time/op		delta
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	402µs ± 0%	415µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
Emit-4	4.25ms ± 0%	4.17ms ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	266ns ± 0%	276ns ± 0%	~	(p=1.000 n=1+1)
ExportType/simple_type-4	77.6ns ± 0%	78.2ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
FlowTokenContract-4	588µs ± 0%	597µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	20.9µs ± 0%	21.7µs ± 0%	~	(p=1.000 n=1+1)
InterpretRecursionFib-4	2.06ms ± 0%	2.17ms ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	860ns ± 0%	847ns ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4	338ns ± 0%	322ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
QualifiedIdentifierCreation/One_level-4	2.54ns ± 0%	2.49ns ± 0%	~	(p=1.000 n=1+1)
QualifiedIdentifierCreation/Three_levels-4	84.3ns ± 0%	80.7ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	607µs ± 0%	599µs ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransferVM-4	644µs ± 0%	651µs ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	2.77ms ± 0%	2.86ms ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	12.8ms ± 0%	12.3ms ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	15.5µs ± 0%	15.2µs ± 0%	~	(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-4	28.6µs ± 0%	29.0µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
SuperTypeInference/arrays-4	222ns ± 0%	229ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/composites-4	94.4ns ± 0%	105.2ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/integers-4	330ns ± 0%	317ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	60.1ns ± 0%	62.5ns ± 0%	~	(p=1.000 n=1+1)

	alloc/op		delta
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	152kB ± 0%	152kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
Emit-4	1.47MB ± 0%	1.46MB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	120B ± 0%	120B ± 0%	~	(all equal)
ExportType/simple_type-4	0.00B	0.00B	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
FlowTokenContract-4	215kB ± 0%	215kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	8.30kB ± 0%	8.30kB ± 0%	~	(all equal)
InterpretRecursionFib-4	1.19MB ± 0%	1.19MB ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	976B ± 0%	976B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	232B ± 0%	232B ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
QualifiedIdentifierCreation/One_level-4	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	64.0B ± 0%	64.0B ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	158kB ± 0%	158kB ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransferVM-4	173kB ± 0%	173kB ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	1.76MB ± 0%	1.77MB ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	9.27MB ± 0%	9.26MB ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	8.01kB ± 0%	7.99kB ± 0%	~	(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-4	9.80kB ± 0%	9.80kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
SuperTypeInference/arrays-4	72.0B ± 0%	72.0B ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00B	0.00B	~	(all equal)
SuperTypeInference/integers-4	0.00B	0.00B	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	32.0B ± 0%	32.0B ± 0%	~	(all equal)

	allocs/op		delta
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	2.46k ± 0%	2.46k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
Emit-4	39.0k ± 0%	39.0k ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
ExportType/simple_type-4	0.00	0.00	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
FlowTokenContract-4	3.47k ± 0%	3.47k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	176 ± 0%	176 ± 0%	~	(all equal)
InterpretRecursionFib-4	17.7k ± 0%	17.7k ± 0%	~	(all equal)
NewInterpreter/new_interpreter-4	15.0 ± 0%	15.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	4.00 ± 0%	4.00 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
QualifiedIdentifierCreation/One_level-4	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	2.00 ± 0%	2.00 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	2.98k ± 0%	2.98k ± 0%	~	(all equal)
RuntimeFungibleTokenTransferVM-4	3.04k ± 0%	3.04k ± 0%	~	(all equal)
RuntimeResourceDictionaryValues-4	36.7k ± 0%	36.7k ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	159k ± 0%	159k ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	113 ± 0%	113 ± 0%	~	(all equal)
RuntimeVMInvokeContractImperativeFib-4	197 ± 0%	197 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
SuperTypeInference/arrays-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00	0.00	~	(all equal)
SuperTypeInference/integers-4	0.00	0.00	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)

turbolent · 2026-01-05T17:40:22Z

Replaced by #4400

Initial plan

7cb92fd

Copilot AI assigned Copilot and turbolent Jan 4, 2026

Copilot started work on behalf of turbolent January 4, 2026 17:46 View session

Copilot AI and others added 2 commits January 4, 2026 17:53

Port PR #4397: Check move operator for resource-typed extra arguments

4ae07e4

Co-authored-by: turbolent <51661+turbolent@users.noreply.github.com>

Remove .orig files and add to .gitignore

dc838ec

Co-authored-by: turbolent <51661+turbolent@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Port changes from pull request 4397 to master branch~~ Port #4397: Check move operator for resource-typed extra arguments Jan 4, 2026

Copilot finished work on behalf of turbolent January 4, 2026 17:55

Copilot AI requested a review from turbolent January 4, 2026 17:55

Copilot started work on behalf of turbolent January 4, 2026 17:59 View session

Copilot finished work on behalf of turbolent January 4, 2026 18:02

SupunS added the Bugfix label Jan 5, 2026

SupunS mentioned this pull request Jan 5, 2026

Check move operator for resource-typed extra arguments #4400

Merged

6 tasks

turbolent closed this Jan 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Port #4397: Check move operator for resource-typed extra arguments#4399

Port #4397: Check move operator for resource-typed extra arguments#4399
Copilot wants to merge 3 commits intomasterfrom
copilot/port-pull-4397-to-master

Copilot AI commented Jan 4, 2026 •

edited

Loading

Uh oh!

turbolent commented Jan 4, 2026

Uh oh!

Copilot AI commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

turbolent commented Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

Copilot AI commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

turbolent commented Jan 4, 2026

Uh oh!

Copilot AI commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Dependency Review

Scanned Files

Uh oh!

github-actions bot commented Jan 5, 2026

Benchstat comparison

Uh oh!

turbolent commented Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jan 4, 2026 •

edited

Loading