Draft
Conversation
Benchstat comparison
Results
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Member
|
oh wow, I piggy-back on this updated test to compare the interpreter ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE - experiment
I was just curious how fvm vs cadence benchmark compares for same (at least close to same) token transfer tx.
I took FVM benchmark @janezpodhostnik added here: https://github.com/onflow/flow-execution-effort-estimation/pull/80
The Tx this runs is:
Then I updated Cadence testRuntimeFungibleTokenTransfer test to match the transaction above (see the change in this PR).
FVM
Benchmark_GlobalRegistry/[TTS_26]-14 230 5,147,458 ns/op
Cadence interpreter
BenchmarkRuntimeFungibleTokenTransferInterpreter-14 690 1,618,031 ns/op 1672294 B/op 36598 allocs/op
Cadence VM
BenchmarkRuntimeFungibleTokenTransferVM-14 972 1,124,029 ns/op 1160718 B/op 26218 allocs/op