[LS] Improve responsiveness of editor diagnostic updates#510
Draft
[LS] Improve responsiveness of editor diagnostic updates#510
Conversation
jribbink
changed the title
jribbink
added
the
Improvement
jribbink
force-pushed
the
jribbink/file-reload
branch
from
2674a1d to
bfea988
Compare
- Extract debouncer into reusable helper type - Move callback logic into named methods on FlowIntegration - Store server reference to avoid closure captures - Reduce nesting and improve readability
- Create FileWatcher in server package to handle .cdc file watching - FileWatcher directly manages cache invalidation and re-checks - Remove callback infrastructure from integration - ConfigManager now only calls server.FileWatcher() for .cdc changes - Clean separation: server owns cache/watching, integration owns Flow state - Eliminates exposed methods like Store(), CollectAffectedOpenRootURIs() - Much cleaner architecture with proper layering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #???
Description
Improves responsiveness of editor diagnostics updates, helping streamline LLM feedback loops when writing Cadence (and general UX).
masterbranchFiles changedin the Github PR explorer