Add tests covering Pool calculations and fixes for tracer bullet paths#20
Merged
nialexsan merged 14 commits intotracer-bulletfrom Jul 9, 2025
Merged
Add tests covering Pool calculations and fixes for tracer bullet paths#20nialexsan merged 14 commits intotracer-bulletfrom
nialexsan merged 14 commits intotracer-bulletfrom
Conversation
sisyphusSmiling
changed the title
… healthAfterWithdrawal
…g on positionHealth()
fix requiredEffectiveDebt calculation
Closed
nialexsan
reviewed
Jul 9, 2025
| // compute how many units of the token would be needed to reach the target health. | ||
| let healthChange = targetHealth - healthAfterWithdrawal | ||
| let requiredEffectiveDebt = healthChange * effectiveCollateralAfterWithdrawal / (targetHealth * targetHealth) | ||
| let requiredEffectiveDebt = effectiveDebtAfterWithdrawal - effectiveCollateralAfterWithdrawal / targetHealth |
Collaborator
There was a problem hiding this comment.
@sisyphusSmiling this is correct formula for required effective debt
nialexsan
approved these changes
Jul 9, 2025
sisyphusSmiling
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
depositTypeinstead ofwithdrawType