Make shell and slurm scheduler report crashes#13
Merged
BerengerBerthoul merged 14 commits intomasterfrom Jan 17, 2025
Merged
Conversation
…ne by send_report.py that is run after the test (even if it segfaults)
couletj
reviewed
Jan 8, 2025
couletj
reviewed
Jan 9, 2025
couletj
reviewed
Jan 10, 2025
Contributor
couletj
left a comment
There was a problem hiding this comment.
Hello, j'ai fais le tour avec qq suggestions pour la doc et dans le code. Je pense que j'ai a peu près compris les idées, l'implémentation est pas évidente car beaucoup de concept et de framework utilisés (MPI, pytest, sockets, slurm, filesystem ...) mais le code est plutot lisible donc bien joué, ça devait pas être évident de rendre ça lisible.
Quelques notes générales :
- Je pense qu'on pourrait enlever la dépendance à numpy, c'est utilisé à deux endroits dont 1 assert
- Est ce que le choix du scheduler seq. par défaut est vraiement pertinent ? Puisqu'il est la seulement pour débuger, il faudrait peut etre mettre le statique à la place non ?
- Est ce qu'on incrémente le num de version suite à ce dev?
9388648 to
f7e07f5
Compare
tracepath utility does not have a '-4' option on older versions, so remove it since it is the default anyway
f7e07f5 to
af20e5f
Compare
b804732 to
fd89241
Compare
ef54118 to
4508055
Compare
Member
Author
|
Thanks for the review. I think I took into account all the suggestions. The only thing that I currently can't change is the default scheduler. The |
4508055 to
f47726d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually contains:
Solves shell scheduler : need to report when test crash #11