New idea, meaningful default prop values#198
Open
balazsorban44 wants to merge 2 commits intoonefinestay:masterfrom
Open
New idea, meaningful default prop values#198balazsorban44 wants to merge 2 commits intoonefinestay:masterfrom
balazsorban44 wants to merge 2 commits intoonefinestay:masterfrom
Conversation
As a solution to onefinestay#197 I propose the following changes: `defaultState` and `stateDefinitions` now has some meaningful default values. It only makes sense, because the user does not need to always define some values when using the Component. It can still be changed afterward if needed.
balazsorban44
changed the title
added trailing commas
Member
|
I think this would be a backwards breaking change for users of this plugin that don't intentionally don't specify In your scenario I wonder if a better error message have helped debug the issue faster? |
Contributor
Author
|
Yes, you are right, but I wonder what is a use case when you don't need to set these props: 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a solution to #197 I propose the following changes:
defaultStateandstateDefinitionsnow has some meaningful default values.It only makes sense, because the user does not need to always define some values when using the Component. It can still be changed afterward if needed.