Skip to content

Nmp Eval Reduction #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheRealGioviok merged 5 commits into from
Jul 21, 2025
Merged

Nmp Eval Reduction #117

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6a8f05f
try NMP eval reduction
ProgramciDusunur Jul 21, 2025
2994a69
bench: 1553698
ProgramciDusunur Jul 21, 2025
76b99b1
remove spaces
ProgramciDusunur Jul 21, 2025
28c9325
Update search.cpp
ProgramciDusunur Jul 21, 2025
1dab9b0
bench: 1553698
ProgramciDusunur Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/search.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
Value last_search_score = -VALUE_INF;
Move last_best_move = Move::none();

const auto print_info_line = [&] {

Check warning on line 82 in src/search.cpp

View workflow job for this annotation

GitHub Actions / Linter / cpp-linter

src/search.cpp:82:16 [readability-identifier-naming] 

invalid case style for constant 'print_info_line'
// Lambda to convert internal units score to uci score. TODO: add eval rescaling here once we get one
auto format_score = [](Value score) {
if (score < -VALUE_WIN && score > -VALUE_MATED) {
Expand Down Expand Up @@ -207,7 +207,7 @@
}

if (!PV_NODE && !is_in_check && depth >= tuned::nmp_depth && static_eval >= beta) {
int R = tuned::nmp_base_r;
int R = tuned::nmp_base_r + std::min(3, (static_eval - beta) / 300);

Check warning on line 210 in src/search.cpp

View workflow job for this annotation

GitHub Actions / Linter / cpp-linter

src/search.cpp:210:18 [readability-identifier-naming] 

invalid case style for variable 'R'
Position pos_after = pos.null_move();

m_repetition_info.push(pos_after.get_hash_key(), true);
Expand All @@ -223,7 +223,7 @@

// Razoring
if (!PV_NODE && !is_in_check && depth <= 7 && static_eval + 260 * depth < alpha) {
const Value razor_score = quiesce(pos, ss, alpha, beta, ply);

Check warning on line 226 in src/search.cpp

View workflow job for this annotation

GitHub Actions / Linter / cpp-linter

src/search.cpp:226:21 [readability-identifier-naming] 

invalid case style for constant 'razor_score'
if (razor_score <= alpha) {
return razor_score;
}
Expand Down Expand Up @@ -319,7 +319,7 @@
if (best_value >= beta && quiet_move(best_move)) {
ss->killer = best_move;

const i32 bonus = std::min(1896, 4 * depth * depth + 120 * depth - 120);

Check warning on line 322 in src/search.cpp

View workflow job for this annotation

GitHub Actions / Linter / cpp-linter

src/search.cpp:322:19 [readability-identifier-naming] 

invalid case style for constant 'bonus'
m_td.history.update_quiet_stats(pos, best_move, bonus);
for (Move quiet : quiets_played) {
m_td.history.update_quiet_stats(pos, quiet, -bonus);
Expand Down Expand Up @@ -437,7 +437,7 @@
}

Value Worker::evaluate(const Position& pos) {
const Color us = pos.active_color();

Check warning on line 440 in src/search.cpp

View workflow job for this annotation

GitHub Actions / Linter / cpp-linter

src/search.cpp:440:17 [readability-identifier-naming] 

invalid case style for constant 'us'
const Color them = invert(us);

Value material =
Expand Down
Loading